[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <85f627d5-7572-1fc7-db1f-bc1337767a68@gmail.com>
Date: Fri, 16 Dec 2022 19:28:13 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Michal Hocko <mhocko@...e.com>,
Mina Almasry <almasrymina@...gle.com>,
Andrew Morton <akpm@...ux-foundation.org>
Cc: Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>,
Johannes Weiner <hannes@...xchg.org>,
Jonathan Corbet <corbet@....net>,
Roman Gushchin <roman.gushchin@...ux.dev>,
Shakeel Butt <shakeelb@...gle.com>,
Muchun Song <songmuchun@...edance.com>,
Huang Ying <ying.huang@...el.com>,
Yang Shi <yang.shi@...ux.alibaba.com>,
Yosry Ahmed <yosryahmed@...gle.com>, weixugc@...gle.com,
fvdl@...gle.com, cgroups@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH] Revert "mm: add nodes= arg to memory.reclaim"
On 12/16/22 16:54, Michal Hocko wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index c8ae7c897f14..74cec76be9f2 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1245,13 +1245,17 @@ PAGE_SIZE multiple when read back.
> This is a simple interface to trigger memory reclaim in the
> target cgroup.
>
> - This file accepts a string which contains the number of bytes to
> - reclaim.
> + This file accepts a single key, the number of bytes to reclaim.
> + No nested keys are currently supported.
>
> Example::
>
> echo "1G" > memory.reclaim
>
> + The interface can be later extended with nested keys to
> + configure the reclaim behavior. For example, specify the
> + type of memory to reclaim from (anon, file, ..).
> +
> Please note that the kernel can over or under reclaim from
> the target cgroup. If less bytes are reclaimed than the
> specified amount, -EAGAIN is returned.
> @@ -1263,13 +1267,6 @@ PAGE_SIZE multiple when read back.
> This means that the networking layer will not adapt based on
> reclaim induced by memory.reclaim.
>
> - This file also allows the user to specify the nodes to reclaim from,
> - via the 'nodes=' key, for example::
> -
> - echo "1G nodes=0,1" > memory.reclaim
> -
> - The above instructs the kernel to reclaim memory from nodes 0,1.
> -
> memory.peak
> A read-only single value file which exists on non-root
> cgroups.
Ah! I forgot to add my Reviewed-by: tag when the original patch was
submitted. However, I was Cc'ed the revert presumably due to Cc: tag in the
original.
In any case, for the documentation part:
Acked-by: Bagas Sanjaya <bagasdotme@...il.com>
--
An old man doll... just what I always wanted! - Clara
Powered by blists - more mailing lists