linux-kernel - Re: [PATCH] KVM: nVMX: Remove outdated comments in nested_vmx_setup_ctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221216014538.3yx5mnmwz2vaa5cy@linux.intel.com>
Date:   Fri, 16 Dec 2022 09:45:38 +0800
From:   Yu Zhang <yu.c.zhang@...ux.intel.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Remove outdated comments in
 nested_vmx_setup_ctls_msrs().

> 
> Eh, just drop the comment.  Pretty obvious this is for secondary execution controls.
Thanks Sean. Well, I agree it is obvious.

This line was kept because there are comments for other groups of
control fields(e.g., exit/entry/pin-based/cpu-based controls etc.)
in nested_vmx_setup_ctls_msrs(). If we do not keep the one for secondary
cpu-based controls, we may just delete other comments as well. But
is that really necessary? 

B.R.
Yu