[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y5x7GXeluFmZ8E0E@hirez.programming.kicks-ass.net>
Date: Fri, 16 Dec 2022 15:05:13 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Kees Cook <keescook@...omium.org>
Cc: Jann Horn <jannh@...gle.com>,
Seth Jenkins <sethjenkins@...gle.com>,
Jonathan Corbet <corbet@....net>,
Andrew Morton <akpm@...ux-foundation.org>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
"Jason A. Donenfeld" <Jason@...c4.com>,
Eric Biggers <ebiggers@...gle.com>,
Huang Ying <ying.huang@...el.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Arnd Bergmann <arnd@...db.de>, linux-doc@...r.kernel.org,
"Guilherme G. Piccoli" <gpiccoli@...lia.com>,
Joel Savitz <jsavitz@...hat.com>,
Laurent Dufour <ldufour@...ux.ibm.com>,
Rob Herring <robh@...nel.org>,
Al Viro <viro@...iv.linux.org.uk>,
Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH] exit: Allow oops_limit to be disabled
On Fri, Dec 02, 2022 at 01:06:21PM -0800, Kees Cook wrote:
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -954,7 +954,7 @@ void __noreturn make_task_dead(int signr)
> * To make sure this can't happen, place an upper bound on how often the
> * kernel may oops without panic().
> */
> - if (atomic_inc_return(&oops_count) >= READ_ONCE(oops_limit))
> + if (atomic_inc_return(&oops_count) >= READ_ONCE(oops_limit) && oops_limit)
> panic("Oopsed too often (kernel.oops_limit is %d)", oops_limit);
>
That's dodgy, please write as:
limit = READ_ONCE(oops_limit);
if (atomic_inc_return(&oops_count) >= limit && limit)
So we don't explicitly add a reload that negates the whole READ_ONCE().
Powered by blists - more mailing lists