linux-kernel - Re: [PATCH] hid: Support for Litra Glow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b787798328560ef3627ba3f8634114d78d3f249a.camel@hadess.net>
Date:   Fri, 16 Dec 2022 15:27:33 +0100
From:   Bastien Nocera <hadess@...ess.net>
To:     Andreas Bergmeier <abergmeier@....net>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Filipe Laíns <lains@...eup.net>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: Support for Litra Glow

On Fri, 2022-12-16 at 10:53 +0100, Bastien Nocera wrote:
> On Thu, 2022-12-15 at 22:09 +0100, Andreas Bergmeier wrote:
> > Tries to implement as general support for Illumination Light as
> > possible. Note that it is singular, which means by Logitech spec we
> > are
> > fine off with just handling one capability/device.
> 
> Your email client absolutely trashed the patch's indentation, it's
> unreadable as-is.
> 
> > Implementation currently only exposes Brightness and On/Off
> > controls.
> > Does currently not expose Color Temperature because LEDs does not
> > support it.
> > 
> > Introduces HIDPP_QUIRK_CLASS_SIMPLE_START to prevent reconnect on
> > startup. Could not get Glow to work with that.
> 
> I'd really rather we didn't introduce a new quirk, but instead fixed
> the fact that we need to restart the HID transport to support 3 (!)
> devices.
> 
> Would something like the attached patch work? I haven't tested it
> yet,
> but if it works for you, I'll test it on the devices I have here.

A tested version attached. I'll need to test it against a T650 before
sending it for review.

View attachment "0001-HID-logitech-hidpp-Don-t-restart-communication-if-no.patch" of type "text/x-patch" (3094 bytes)