[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y5yS8wCnuYGLHMj4@x1n>
Date: Fri, 16 Dec 2022 10:46:59 -0500
From: Peter Xu <peterx@...hat.com>
To: Jeff Xu <jeffxu@...gle.com>
Cc: Kees Cook <keescook@...omium.org>, jeffxu@...omium.org,
skhan@...uxfoundation.org, akpm@...ux-foundation.org,
dmitry.torokhov@...il.com, dverkamp@...omium.org, hughd@...gle.com,
jorgelo@...omium.org, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-mm@...ck.org,
jannh@...gle.com, linux-hardening@...r.kernel.org,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v6 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC
Hi, Jeff,
On Thu, Dec 08, 2022 at 02:55:45PM -0800, Jeff Xu wrote:
> > > + if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) {
[...]
> > > + pr_warn_ratelimited(
> > > + "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=%d '%s'\n",
> > > + task_pid_nr(current), get_task_comm(comm, current));
This will be frequently dumped right now with mm-unstable. Is that what it
wanted to achieve?
[ 10.822575] memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=491 'systemd'
[ 10.824743] memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=495 '(sd-executor)'
...
If there's already a sane default value (and also knobs for the user to
change the default) not sure whether it's saner to just keep it silent as
before?
--
Peter Xu
Powered by blists - more mailing lists