linux-kernel - Re: [PATCH] PCI: dwc: adjust to recent removal of PCI_MSI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221216155304.uckgqbcgotqj6bha@mobilestation>
Date:   Fri, 16 Dec 2022 18:53:04 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
CC:     Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        <linux-pci@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: dwc: adjust to recent removal of PCI_MSI_IRQ_DOMAIN

On Thu, Dec 15, 2022 at 11:34:52AM +0100, Lukas Bulwahn wrote:
> Commit a474d3fbe287 ("PCI/MSI: Get rid of PCI_MSI_IRQ_DOMAIN") removes the
> config PCI_MSI_IRQ_DOMAIN and makes all previous references to that config
> then refer to PCI_MSI instead.
> 
> Commit ba6ed462dcf4 ("PCI: dwc: Add Baikal-T1 PCIe controller support")
> adds the config PCIE_BT1, which following the previous default pattern
> depends on the config PCI_MSI_IRQ_DOMAIN.
> 
> As these two commits were submitted roughly at the same time, the
> refactoring did not take of this occurrence and the addition did not yet
> notice the refactoring.
> 
> Take care of the PCI_MSI config refactoring on this latest addition.

Indeed. I just didn't know about the refactoring. Thanks for submitting
a fixup patch.

Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  drivers/pci/controller/dwc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index a0d2713f0e88..99ec91e2a5cf 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -225,7 +225,7 @@ config PCIE_ARTPEC6_EP
>  config PCIE_BT1
>  	tristate "Baikal-T1 PCIe controller"
>  	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> -	depends on PCI_MSI_IRQ_DOMAIN
> +	depends on PCI_MSI
>  	select PCIE_DW_HOST
>  	help
>  	  Enables support for the PCIe controller in the Baikal-T1 SoC to work
> -- 
> 2.17.1
> 
>