linux-kernel - Re: [PATCHv7 7/7] arm64: dts: rockchip: Add rock-5b board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221216161020.pih47wezxwpinnoo@mercury.elektranox.org>
Date:   Fri, 16 Dec 2022 17:10:20 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Nicolas Dufresne <nicolas.dufresne@...labora.com>
Cc:     Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marc Zyngier <maz@...nel.org>, Jagan Teki <jagan@...eble.ai>,
        Linus Walleij <linus.walleij@...aro.org>,
        Christopher Obbard <chris.obbard@...labora.com>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Michael Riesch <michael.riesch@...fvision.net>
Subject: Re: [PATCHv7 7/7] arm64: dts: rockchip: Add rock-5b board

Hi Nicolas,

On Fri, Dec 16, 2022 at 10:47:44AM -0500, Nicolas Dufresne wrote:
> Hi Sebastian and Christopher,
> 
> Le jeudi 15 décembre 2022 à 19:30 +0100, Sebastian Reichel a écrit :
> > From: Christopher Obbard <chris.obbard@...labora.com>
> > 
> > Add board file for the RK3588 Rock 5B board. This is a basic
> > implementation which just brings up the eMMC and UART which is
> > enough to successfully boot Linux.
> > 
> > The ethernet controller is connected via PCIe so support will
> > come in a follow-up patch.
> > 
> > Signed-off-by: Christopher Obbard <chris.obbard@...labora.com>
> > Reviewed-by: Michael Riesch <michael.riesch@...fvision.net>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile         |  1 +
> >  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 44 +++++++++++++++++++
> >  2 files changed, 45 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 87a853435142..c5bdd0176ce0 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -83,4 +83,5 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > new file mode 100644
> > index 000000000000..baf46bd30b38
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > @@ -0,0 +1,44 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +
> > +/dts-v1/;
> > +
> > +#include "rk3588.dtsi"
> > +
> > +/ {
> > +	model = "Radxa Rock 5B Board";
> > +	compatible = "radxa,rock-5b", "rockchip,rk3588";
> > +
> > +	aliases {
> > +		mmc1 = &sdhci;
> 
> I have no useful knowledge, but it seems the mmc alias don't match the vendor.
> When I run your branch on Rock5B, the EMMC endup on /dev/mmcblk1 (aka mmc1 alias
> I think) while when I boot the vendor kernel, it is always mmcblk0 (aka mmc0
> alias?). Perhaps the vendor didn't add aliases ?
>
> There could also be mainline rules to number based on the boot order. In this
> case, the difference would be acceptable, since SPL boot order is (usb?) > SD
> Card > EMMC > SPI NOR. Though, the SPL is picked from the opposite order (spi,
> emmc, sd card). Anyway, I'm just trying to express that I noticed a difference,
> and its not guarantied to be a bug.

The public vendor tree specifies the same alias, so I expected the
vendor kernel to have the eMMC at /dev/mmcblk1:

https://github.com/radxa/kernel/blob/stable-5.10-rock5/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts#L31

checking the vendor tree again, it also has a rk3588-rock-5b-v11.dts,
which does not have any aliases configured. Are you using that?

-- Sebastian

> 
> > +		serial2 = &uart2;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial2:1500000n8";
> > +	};
> > +
> > +	vcc5v0_sys: vcc5v0-sys-regulator {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc5v0_sys";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-max-microvolt = <5000000>;
> > +	};
> > +};
> > +
> > +&sdhci {
> > +	bus-width = <8>;
> > +	no-sdio;
> > +	no-sd;
> > +	non-removable;
> > +	max-frequency = <200000000>;
> > +	mmc-hs400-1_8v;
> > +	mmc-hs400-enhanced-strobe;
> > +	status = "okay";
> > +};
> > +
> > +&uart2 {
> > +	pinctrl-0 = <&uart2m0_xfer>;
> > +	status = "okay";
> > +};
> > -- 
> > 2.39.0
> > 
> > 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)