linux-kernel - Re: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 18:25:13 -0800
From:   Elliot Berman <quic_eberman@...cinc.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Bjorn Andersson <quic_bjorande@...cinc.com>,
        Murali Nalajala <quic_mnalajal@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        "Srivatsa Vaddagiri" <quic_svaddagi@...cinc.com>,
        Carl van Schaik <quic_cvanscha@...cinc.com>,
        Prakruthi Deepak Heragu <quic_pheragu@...cinc.com>,
        Arnd Bergmann <arnd@...db.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core



On 12/12/2022 10:26 PM, Greg Kroah-Hartman wrote:
> On Mon, Dec 12, 2022 at 03:46:53PM -0800, Elliot Berman wrote:
>>
>> Reference counting is not needed on the gh_rm_rpc object because its only
>> client (the VM manager) is torn down before the gh_rm_rpc.
> 
> So again, who controls the lifecycle of it?  Where is the reference
> count for the structure as it is pointing to reference counted memory?

Had some internal review and I think I'm now taking better care of this 
(and the device situation in the other mail). I will send out next 
revision soon.

In summary:

  - Incrementing platform device's refcount when creating a new VM since 
it spawns new file descriptor that could remain open after closing the 
main miscdevice.
  - Re-organizing vm_manager so it is much more like a library than a 
separate device.

Thanks,
Elliot