lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Dec 2022 09:33:19 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: Bjorn Helgaas <helgaas@...nel.org>, Kurt Schwemmer <kurt.schwemmer@...rosemi.com> Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com> Subject: Re: [PATCH v2 2/2] PCI: switchtec: Return -EFAULT for copy_to_user() errors On 2022-12-16 09:21, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@...gle.com> > > switchtec_dev_read() didn't handle copy_to_user() errors correctly: it > assigned "rc = -EFAULT", but actually returned either "size", -ENXIO, or > -EBADMSG instead. > > Update the failure cases to unlock mrpc_mutex and return -EFAULT directly. > > Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver") > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com> Looks good to me thanks! Reviewed-by: Logan Gunthorpe <logang@...tatee.com> Logan
Powered by blists - more mailing lists