linux-kernel - Re: [PATCH 0/2] drm: Add component_match_add_of and convert users of drm_of_component_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2db73405-464f-6980-a7c1-7fe232611331@arm.com>
Date:   Fri, 16 Dec 2022 17:41:40 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Sean Anderson <sean.anderson@...o.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Alain Volmat <alain.volmat@...s.st.com>,
        Brian Starkey <brian.starkey@....com>,
        Chen Feng <puck.chen@...ilicon.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Joerg Roedel <joro@...tes.org>,
        John Stultz <jstultz@...gle.com>,
        Jyri Sarha <jyri.sarha@....fi>,
        Liam Girdwood <lgirdwood@...il.com>,
        Liviu Dudau <liviu.dudau@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Mali DP Maintainers <malidp@...s.arm.com>,
        Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mihail Atanassov <mihail.atanassov@....com>,
        Paul Cercueil <paul@...pouillou.net>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Clark <robdclark@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Samuel Holland <samuel@...lland.org>,
        Sean Paul <sean@...rly.run>, Takashi Iwai <tiwai@...e.com>,
        Tian Tao <tiantao6@...ilicon.com>,
        Tomi Valkeinen <tomba@...nel.org>,
        Will Deacon <will@...nel.org>,
        Xinliang Liu <xinliang.liu@...aro.org>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Yong Wu <yong.wu@...iatek.com>, alsa-devel@...a-project.org,
        etnaviv@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-mips@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 0/2] drm: Add component_match_add_of and convert users of
 drm_of_component_match_add

On 2022-12-16 17:08, Sean Anderson wrote:
> On 11/3/22 14:22, Sean Anderson wrote:
>> This series adds a new function component_match_add_of to simplify the
>> common case of calling component_match_add_release with
>> component_release_of and component_compare_of. There is already
>> drm_of_component_match_add, which allows for a custom compare function.
>> However, all existing users just use component_compare_of (or an
>> equivalent).
>>
>> I can split the second commit up if that is easier to review.
>>
>>
>> Sean Anderson (2):
>>    component: Add helper for device nodes
>>    drm: Convert users of drm_of_component_match_add to
>>      component_match_add_of
>>
>>   .../gpu/drm/arm/display/komeda/komeda_drv.c   |  6 ++--
>>   drivers/gpu/drm/arm/hdlcd_drv.c               |  9 +-----
>>   drivers/gpu/drm/arm/malidp_drv.c              | 11 +------
>>   drivers/gpu/drm/armada/armada_drv.c           | 10 ++++---
>>   drivers/gpu/drm/drm_of.c                      | 29 +++----------------
>>   drivers/gpu/drm/etnaviv/etnaviv_drv.c         |  4 +--
>>   .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |  3 +-
>>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |  3 +-
>>   drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  4 +--
>>   drivers/gpu/drm/msm/msm_drv.c                 | 14 ++++-----
>>   drivers/gpu/drm/sti/sti_drv.c                 |  3 +-
>>   drivers/gpu/drm/sun4i/sun4i_drv.c             |  3 +-
>>   drivers/gpu/drm/tilcdc/tilcdc_external.c      | 10 ++-----
>>   drivers/iommu/mtk_iommu.c                     |  3 +-
>>   drivers/iommu/mtk_iommu_v1.c                  |  3 +-
>>   include/drm/drm_of.h                          | 12 --------
>>   include/linux/component.h                     |  9 ++++++
>>   sound/soc/codecs/wcd938x.c                    |  6 ++--
>>   18 files changed, 46 insertions(+), 96 deletions(-)
>>
> 
> ping?
> 
> Should I send a v2 broken up like Mark suggested?

FWIW you'll need to rebase the IOMMU changes on 6.2-rc1 anyway - 
mtk_iommu stops using component_match_add_release() at all.

Thanks,
Robin.