linux-kernel - Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5zErm1YuXlBBHYw@google.com>
Date:   Fri, 16 Dec 2022 11:19:10 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     joewu(吳仲振) <joewu@....com>
Cc:     Joe Wu <joewu@....corp-partner.google.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Xiang wangx <wangxiang@...rlc.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Derek Huang <derekhuang@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Benson Leung <bleung@...omium.org>,
        Daisuke Nojiri <dnojiri@...omium.org>,
        Prashant Malani <pmalani@...omium.org>,
        Furquan Shaikh <furquan@...omium.org>,
        Tzung-Bi Shih <tzungbi@...nel.org>,
        "chrome-platform@...ts.linux.dev" <chrome-platform@...ts.linux.dev>,
        Douglas Anderson <dianders@...omium.org>,
        "Dustin L . Howett" <dustin@...ett.net>,
        Guenter Roeck <groeck@...omium.org>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function

On Fri, Dec 16, 2022 at 01:36:24AM +0000, joewu(吳仲振) wrote:
> Hi Dmitry,
> 
> Thank you for comments. I will try to give a clear description and sent the patch again.
> Actually, the function of "leave PC(cros) mode" button is to implement 'lock the screen' in chromeOS.
> Google suggests us to sent 'F13' key to lock the screen, could we do it or do you have any suggestion? 

Is this different from the normal power button? If it is the key with
"padlock" glyph you want to map it to KEY_SLEEP or KEY_SCREENLOCK.

We should no longer use or recommend overriding F13 for this.  Is there
an internal Google bug for this? Could you add dtor@...gle.com there?

Thanks.

-- 
Dmitry