linux-kernel - Re: [PATCH] efi: random: fix NULL-deref when refreshing seed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5zJT9Z37GSpd59l@zx2c4.com>
Date:   Fri, 16 Dec 2022 12:39:56 -0700
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     Ard Biesheuvel <ardb@...nel.org>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Steev Klimaszewski <steev@...i.org>,
        Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH] efi: random: fix NULL-deref when refreshing seed

On Fri, Dec 16, 2022 at 10:15:14AM +0100, Johan Hovold wrote:
> Do not try to refresh the RNG seed in case the firmware does not support
> setting variables.
> 
> This is specifically needed to prevent a NULL-pointer dereference on the
> Lenovo X13s with some firmware revisions.
> 
> Fixes: e7b813b32a42 ("efi: random: refresh non-volatile random seed when RNG is initialized")
> Reported-by: Steev Klimaszewski <steev@...i.org>
> Reported-by: Bjorn Andersson <andersson@...nel.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---

Thanks very much for this, and sorry for the breakage. I'll try to get
this in before rc1 is cut, as I've got some other changes scheduled for
late in the merge window to send anyway.

Jason