linux-kernel - Re: [PATCH v3] rtc: abx80x: Add nvmem support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Dec 2022 05:15:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sean Anderson <sean.anderson@...o.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Sean Anderson <sean.anderson@...o.com>
Subject: Re: [PATCH v3] rtc: abx80x: Add nvmem support

Hi Sean,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v6.1]
[also build test WARNING on linus/master]
[cannot apply to abelloni/rtc-next next-20221216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/rtc-abx80x-Add-nvmem-support/20221217-011601
patch link:    https://lore.kernel.org/r/20221216170643.2953920-1-sean.anderson%40seco.com
patch subject: [PATCH v3] rtc: abx80x: Add nvmem support
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/853a2a957b8626c0dce3f71d3055d6a83b8f5c18
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sean-Anderson/rtc-abx80x-Add-nvmem-support/20221217-011601
        git checkout 853a2a957b8626c0dce3f71d3055d6a83b8f5c18
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/rtc/rtc-abx80x.c: In function 'abx80x_setup_nvmem':
>> drivers/rtc/rtc-abx80x.c:738:24: warning: unused variable 'dev' [-Wunused-variable]
     738 |         struct device *dev = &priv->client->dev;
         |                        ^~~


vim +/dev +738 drivers/rtc/rtc-abx80x.c

   735	
   736	static int abx80x_setup_nvmem(struct abx80x_priv *priv)
   737	{
 > 738		struct device *dev = &priv->client->dev;
   739		struct nvmem_config config = {
   740			.type = NVMEM_TYPE_BATTERY_BACKED,
   741			.reg_read = abx80x_nvmem_read,
   742			.reg_write = abx80x_nvmem_write,
   743			.size = ABX8XX_RAM_SIZE,
   744			.priv = priv,
   745		};
   746	
   747		return devm_rtc_nvmem_register(priv->rtc, &config);
   748	}
   749	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (291974 bytes)