linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: sa8295p-adp: use pm8450a dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32bfd604-6fb6-51c6-5847-c87832ef1ebc@linaro.org>
Date:   Sat, 17 Dec 2022 15:22:25 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Eric Chanudet <echanude@...hat.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andrew Halaney <ahalaney@...hat.com>,
        Brian Masney <bmasney@...hat.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sa8295p-adp: use pm8450a dtsi



On 16.12.2022 20:56, Eric Chanudet wrote:
> On Thu, Dec 15, 2022 at 02:01:09PM +0100, Konrad Dybcio wrote:
>> On 14.12.2022 22:09, Eric Chanudet wrote:
>>> Include the dtsi to use a single pmic descriptions.
>>> Both sa8295p-adp and sa8540p-adp have the same spmi pmic apparently.
>>>
>>> Signed-off-by: Eric Chanudet <echanude@...hat.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 79 +-----------------------
>>>  1 file changed, 1 insertion(+), 78 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
>>> index 84cb6f3eeb56..889259df3287 100644
>>> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
>>> @@ -11,6 +11,7 @@
>>>  #include <dt-bindings/spmi/spmi.h>
>>>  
>>>  #include "sa8540p.dtsi"
>>> +#include "pm8450a.dtsi"
>> I feel like naming it  sa8540p-pmics.dtsi (like sc8280xp-pmics.dtsi)
>> would be more representative of what's really going on (unless it's
>> a single chip providing 4 virtual PMICs on different SIDs).
> 
> I can make a v3 renaming this. The initial commit from Parikshit
> mentions it is to be re-used on sa8540 based boards.
> 
> Side note: A quick look also shows pm8450.dtsi[1] is not included by
> any of its intended targets (sm8350 and sm8450 IIUC). Was this lost?
sm8450 only. They were not included, as SPMI was not enabled on sm8450.
They will be included in 6.3 once that's merged.

Konrad
> 
> Thanks,
> 
> [1] https://lore.kernel.org/r/20220226205035.1826360-8-dmitry.baryshkov@linaro.org
>