linux-kernel - Re: [PATCH 0/2] kexec: Remove unnecessary arch hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221217155842.GA389338@bhelgaas>
Date:   Sat, 17 Dec 2022 09:58:42 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Baoquan He <bhe@...hat.com>
Cc:     Eric Biederman <ebiederm@...ssion.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 0/2] kexec: Remove unnecessary arch hook

On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote:
> On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > There are no arch-specific things in arch_kexec_kernel_image_load(), so
> > remove it and just use the generic version.
> 
> I ever posted below patch to do the same thing, Andrew only picked the
> memory leak fixing patch.
> 
> [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load
> https://lore.kernel.org/all/20220223113225.63106-3-bhe@redhat.com/T/#u

Indeed!  Sorry, I wasn't aware of your previous work.  If you repost
it, cc me and I'll be glad to help review it.

> > Bjorn Helgaas (2):
> >   x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
> >   kexec: Remove unnecessary arch_kexec_kernel_image_load()
> > 
> >  arch/x86/include/asm/kexec.h       |  3 ---
> >  arch/x86/kernel/machine_kexec_64.c | 11 -----------
> >  include/linux/kexec.h              |  8 --------
> >  kernel/kexec_file.c                |  6 +++---
> >  4 files changed, 3 insertions(+), 25 deletions(-)