[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c21996f3-0f1d-8b77-95fb-ab98f3a28913@denx.de>
Date: Sat, 17 Dec 2022 20:46:31 +0100
From: Marek Vasut <marex@...x.de>
To: Richard Zhu <hongxing.zhu@....com>, vkoul@...nel.org,
a.fatoum@...gutronix.de, p.zabel@...gutronix.de,
l.stach@...gutronix.de, bhelgaas@...gle.com,
lorenzo.pieralisi@....com, robh@...nel.org, shawnguo@...nel.org,
alexander.stein@...tq-group.com, richard.leitner@...ux.dev
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, kernel@...gutronix.de,
linux-imx@....com
Subject: Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY
support
On 10/13/22 03:47, Richard Zhu wrote:
Hi,
[...]
> @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
> return PTR_ERR(imx8_phy->reset);
> }
>
> + if (imx8_phy->drvdata->variant == IMX8MP) {
> + imx8_phy->perst =
> + devm_reset_control_get_exclusive(dev, "perst");
> + if (IS_ERR(imx8_phy->perst))
> + dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
I just notice this , are we missing return here ?
That is ... return dev_err_probe(...) ?
> + "Failed to get PCIE PHY PERST control\n");
> + }
[...]
Powered by blists - more mailing lists