lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212170910.LL9FaOmo-lkp@intel.com>
Date:   Sat, 17 Dec 2022 09:58:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org
Cc:     oe-kbuild-all@...ts.linux.dev, hannes@...xchg.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        bfoster@...hat.com, willy@...radead.org, kernel-team@...a.com
Subject: Re: [PATCH v4 3/4] cachestat: implement cachestat syscall

Hi Nhat,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shuah-kselftest/next]
[also build test ERROR on shuah-kselftest/fixes tip/x86/asm akpm-mm/mm-everything linus/master v6.1 next-20221216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/cachestat-a-new-syscall-for-page-cache-state-of-files/20221217-032254
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
patch link:    https://lore.kernel.org/r/20221216192149.3902877-4-nphamcs%40gmail.com
patch subject: [PATCH v4 3/4] cachestat: implement cachestat syscall
config: arm64-allyesconfig
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/85fdb04584b3d9a3b90d2c63794ec65e8d996b18
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nhat-Pham/cachestat-a-new-syscall-for-page-cache-state-of-files/20221217-032254
        git checkout 85fdb04584b3d9a3b90d2c63794ec65e8d996b18
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 prepare

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/uapi/linux/mman.h:5,
                    from include/linux/fs.h:49,
                    from arch/arm64/include/asm/elf.h:141,
                    from include/linux/elf.h:6,
                    from include/linux/module.h:19,
                    from include/linux/device/driver.h:21,
                    from include/linux/device.h:32,
                    from include/linux/acpi.h:15,
                    from include/acpi/apei.h:9,
                    from include/acpi/ghes.h:5,
                    from include/linux/arm_sdei.h:8,
                    from arch/arm64/kernel/asm-offsets.c:10:
   arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_prot_bits':
>> arch/arm64/include/asm/mman.h:15:24: error: 'VM_ARM64_BTI' undeclared (first use in this function); did you mean 'ARM64_BTI'?
      15 |                 ret |= VM_ARM64_BTI;
         |                        ^~~~~~~~~~~~
         |                        ARM64_BTI
   arch/arm64/include/asm/mman.h:15:24: note: each undeclared identifier is reported only once for each function it appears in
>> arch/arm64/include/asm/mman.h:18:24: error: 'VM_MTE' undeclared (first use in this function)
      18 |                 ret |= VM_MTE;
         |                        ^~~~~~
   arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_flag_bits':
>> arch/arm64/include/asm/mman.h:32:24: error: 'VM_MTE_ALLOWED' undeclared (first use in this function)
      32 |                 return VM_MTE_ALLOWED;
         |                        ^~~~~~~~~~~~~~
   arch/arm64/include/asm/mman.h: In function 'arch_validate_flags':
   arch/arm64/include/asm/mman.h:59:29: error: 'VM_MTE' undeclared (first use in this function)
      59 |         return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED);
         |                             ^~~~~~
   arch/arm64/include/asm/mman.h:59:52: error: 'VM_MTE_ALLOWED' undeclared (first use in this function)
      59 |         return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED);
         |                                                    ^~~~~~~~~~~~~~
   make[2]: *** [scripts/Makefile.build:118: arch/arm64/kernel/asm-offsets.s] Error 1
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:1270: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:231: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +15 arch/arm64/include/asm/mman.h

8ef8f360cf30be Dave Martin     2020-03-16   8  
8ef8f360cf30be Dave Martin     2020-03-16   9  static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot,
8ef8f360cf30be Dave Martin     2020-03-16  10  	unsigned long pkey __always_unused)
8ef8f360cf30be Dave Martin     2020-03-16  11  {
9f3419315f3cdc Catalin Marinas 2019-11-27  12  	unsigned long ret = 0;
9f3419315f3cdc Catalin Marinas 2019-11-27  13  
8ef8f360cf30be Dave Martin     2020-03-16  14  	if (system_supports_bti() && (prot & PROT_BTI))
9f3419315f3cdc Catalin Marinas 2019-11-27 @15  		ret |= VM_ARM64_BTI;
8ef8f360cf30be Dave Martin     2020-03-16  16  
9f3419315f3cdc Catalin Marinas 2019-11-27  17  	if (system_supports_mte() && (prot & PROT_MTE))
9f3419315f3cdc Catalin Marinas 2019-11-27 @18  		ret |= VM_MTE;
9f3419315f3cdc Catalin Marinas 2019-11-27  19  
9f3419315f3cdc Catalin Marinas 2019-11-27  20  	return ret;
8ef8f360cf30be Dave Martin     2020-03-16  21  }
8ef8f360cf30be Dave Martin     2020-03-16  22  #define arch_calc_vm_prot_bits(prot, pkey) arch_calc_vm_prot_bits(prot, pkey)
8ef8f360cf30be Dave Martin     2020-03-16  23  
9f3419315f3cdc Catalin Marinas 2019-11-27  24  static inline unsigned long arch_calc_vm_flag_bits(unsigned long flags)
9f3419315f3cdc Catalin Marinas 2019-11-27  25  {
9f3419315f3cdc Catalin Marinas 2019-11-27  26  	/*
9f3419315f3cdc Catalin Marinas 2019-11-27  27  	 * Only allow MTE on anonymous mappings as these are guaranteed to be
9f3419315f3cdc Catalin Marinas 2019-11-27  28  	 * backed by tags-capable memory. The vm_flags may be overridden by a
9f3419315f3cdc Catalin Marinas 2019-11-27  29  	 * filesystem supporting MTE (RAM-based).
9f3419315f3cdc Catalin Marinas 2019-11-27  30  	 */
9f3419315f3cdc Catalin Marinas 2019-11-27  31  	if (system_supports_mte() && (flags & MAP_ANONYMOUS))
9f3419315f3cdc Catalin Marinas 2019-11-27 @32  		return VM_MTE_ALLOWED;
9f3419315f3cdc Catalin Marinas 2019-11-27  33  
9f3419315f3cdc Catalin Marinas 2019-11-27  34  	return 0;
9f3419315f3cdc Catalin Marinas 2019-11-27  35  }
9f3419315f3cdc Catalin Marinas 2019-11-27  36  #define arch_calc_vm_flag_bits(flags) arch_calc_vm_flag_bits(flags)
9f3419315f3cdc Catalin Marinas 2019-11-27  37  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (362382 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ