linux-kernel - Re: [PATCH 1/6] Adjust maximum MSIZE to account for p9 header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4530979.Ltmge6kleC@silver>
Date:   Sun, 18 Dec 2022 15:49:18 +0100
From:   Christian Schoenebeck <linux_oss@...debyte.com>
To:     v9fs-developer@...ts.sourceforge.net, asmadeus@...ewreck.org,
        rminnich@...il.com, lucho@...kov.net,
        Eric Van Hensbergen <evanhensbergen@...oud.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Eric Van Hensbergen <evanhensbergen@...oud.com>
Subject: Re: [PATCH 1/6] Adjust maximum MSIZE to account for p9 header

On Saturday, December 17, 2022 7:52:05 PM CET Eric Van Hensbergen wrote:
> Add maximum p9 header size to MSIZE to make sure we can
> have page aligned data.
> 
> Signed-off-by: Eric Van Hensbergen <evanhensbergen@...oud.com>
> ---
>  net/9p/client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/9p/client.c b/net/9p/client.c
> index fef6516a0639..416baf2f1edf 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -28,7 +28,7 @@
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/9p.h>
>  
> -#define DEFAULT_MSIZE (128 * 1024)
> +#define DEFAULT_MSIZE ((128 * 1024) + P9_HDRSZ)

Adding 7 would make what page aligned exactly, the payload? And how?

>  
>  /* Client Option Parsing (code inspired by NFS code)
>   *  - a little lazy - parse all client options
>