[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221218141638.41d8d32f@hermes.local>
Date: Sun, 18 Dec 2022 14:16:38 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
Cc: davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
kuba@...nel.org, a@...table.cc, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not
generating IPv6 link local address
On Mon, 19 Dec 2022 10:57:17 +1300
Thomas Winter <Thomas.Winter@...iedtelesis.co.nz> wrote:
> + switch (dev->type) {
> + #if IS_ENABLED(CONFIG_IPV6_SIT)
> + case ARPHRD_SIT:
> + addrconf_sit_config(dev);
> + break;
> + #endif
> + #if IS_ENABLED(CONFIG_NET_IPGRE) || IS_ENABLED(CONFIG_IPV6_GRE)
> + case ARPHRD_IP6GRE:
> + case ARPHRD_IPGRE:
> + addrconf_gre_config(dev);
> + break;
> + #endif
Linux kernel style is to start any conditional compilation in first column
I.e.
#if IS_ENABLED(CONFIG_IPV6_SIT)
Not
#if IS_ENABLED(CONFIG_IPV6_SIT)
Powered by blists - more mailing lists