linux-kernel - Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Add GPI DMA nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221218102336.io5epil54gwlqqqh@SoMainline.org>
Date:   Sun, 18 Dec 2022 11:23:36 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     phone-devel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        Lux Aliaga <they@...t.lgbt>,
        Richard Acayan <mailingradian@...il.com>,
        linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Add GPI DMA nodes

On 2022-12-17 15:35:18, Konrad Dybcio wrote:
> 
> 
> On 17.12.2022 00:15, Marijn Suijten wrote:
> > From: Martin Botka <martin.botka@...ainline.org>
> > 
> > Add nodes for GPI DMA hosts on SM6125.
> > 
> > Signed-off-by: Martin Botka <martin.botka@...ainline.org>
> > [Marijn: reorder properties, use sdm845 fallback compatible, disable by
> >  default, use 3 instead of 5 dma cells]
> > Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm6125.dtsi | 37 ++++++++++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> > index a205121ab4a7..abcd634c4f6d 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> > @@ -5,6 +5,7 @@
> >  
> >  #include <dt-bindings/clock/qcom,gcc-sm6125.h>
> >  #include <dt-bindings/clock/qcom,rpmcc.h>
> > +#include <dt-bindings/dma/qcom-gpi.h>
> >  #include <dt-bindings/gpio/gpio.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/power/qcom-rpmpd.h>
> > @@ -510,6 +511,42 @@ sdhc_2: mmc@...4000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		gpi_dma0: dma-controller@...0000 {
> > +			compatible = "qcom,sm6125-gpi-dma", "qcom,sdm845-gpi-dma";
> > +			reg = <0x04a00000 0x60000>;
> > +			interrupts = <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH>,
> > +				     <GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH>;
> > +			dma-channels = <8>;
> > +			dma-channel-mask = <0x1f>;
> > +			iommus = <&apps_smmu 0x0136 0x0>;
> The stream id does not need the leading zero.

Good catch!  Will clean this up for V2.

> You made the mask a decimal zero in the previous patchset, please
> decide on one convention. Masks are generally more useful as hex,
> but for zero values I suppose zero is less noise for the same thing..

The _vast majority_ of qcom dts uses 0x0, I'll fix that in the previous
patch series.  Looks like I did even clean that up when directly
transplanting that patch ("Add apps_smmu with streamID to SDHCI 1/2
nodes") to sm6350 even...

> The DMA nodes however, look good otherwise.

And they work great, too!

- Marijn