[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1633NR.JIUCB2Y1JAXI3@somainline.org>
Date: Sun, 18 Dec 2022 12:13:13 +0100
From: Martin Botka <martin.botka@...ainline.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...ainline.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Jami Kettunen <jami.kettunen@...ainline.org>,
Johan Hovold <johan+linaro@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Robert Marko <robimarko@...il.com>,
Linus Walleij <linus.walleij@...aro.org>,
Nuno Sá <nuno.sa@...log.com>,
linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: qcom-spmi-adc5: Suppress probe-deferral error
message
On Fri, Dec 16 2022 at 08:09:45 PM +01:00:00, Marijn Suijten
<marijn.suijten@...ainline.org> wrote:
> Much like 807efb7102e8 ("thermal: qcom-spmi-adc-tm5: suppress
> probe-deferral error message") the ADC5 driver also spams a similar
> probe-deferral error on startup when a channel is not yet available:
>
> [ 0.343136] qcom-spmi-adc-tm5 1c40000.spmi:pmic@0:adc-tm@...0:
> get dt data failed: -517
>
> Suppress it by using dev_err_probe instead, which also takes care of
> storing the message as reason for deferring.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> ---
> drivers/iio/adc/qcom-spmi-adc5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c
> b/drivers/iio/adc/qcom-spmi-adc5.c
> index 821fee60a765..69cc36004b5a 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -894,10 +894,8 @@ static int adc5_probe(struct platform_device
> *pdev)
> mutex_init(&adc->lock);
>
> ret = adc5_get_fw_data(adc);
> - if (ret) {
> - dev_err(dev, "adc get dt data failed\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "adc get dt data failed\n");
>
Reviewed-by: Martin Botka <martin.botka@...ainline.org>
-Martin
> irq_eoc = platform_get_irq(pdev, 0);
> if (irq_eoc < 0) {
> --
> 2.39.0
>
Powered by blists - more mailing lists