linux-kernel - Re: [PATCH] mm/slab: remove unused slab_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221218121204.27720-1-gouhao@uniontech.com>
Date:   Sun, 18 Dec 2022 20:12:04 +0800
From:   gouhao@...ontech.com
To:     42.hyeyoo@...il.com
Cc:     akpm@...ux-foundation.org, cl@...ux.com, gouhao@...ontech.com,
        gouhaojake@....com, iamjoonsoo.kim@....com, keescook@...omium.org,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, mingo@...e.hu, penberg@...nel.org,
        rientjes@...gle.com, roman.gushchin@...ux.dev, vbabka@...e.cz
Subject: Re: [PATCH] mm/slab: remove unused slab_early_init

Thanks for your review, i will fix it in next version patch. :)


Thanks,
Gou Hao
> 
> > so early during bootup.
> > 
> > The only user of 'slab_early_init' was removed in commit
> > '3217fd9bdf00 ("mm/slab: make criteria for off slab
> > determination robust and simple")'.
> > 
> > Signed-off-by: Gou Hao <gouhao@...ontech.com>
> > ---
> >  mm/slab.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/mm/slab.c b/mm/slab.c
> > index 7a269db050ee..ede1f29fd81c 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
> >  static inline void fixup_slab_list(struct kmem_cache *cachep,
> >  				struct kmem_cache_node *n, struct slab *slab,
> >  				void **list);
> > -static int slab_early_init = 1;
> >  
> >  #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))
> >  
> > @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)
> >  	slab_state = PARTIAL_NODE;
> >  	setup_kmalloc_cache_index_table();
> >  
> > -	slab_early_init = 0;
> > -
> >  	/* 5) Replace the bootstrap kmem_cache_node */
> >  	{
> >  		int nid;
> > -- 
> > 2.20.1
> 
> Nice cleanup, thanks!
> 
> Acked-by: Hyeonggon Yoo <42.hyeyoo@...il.com>