[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y6AVkwh+V/PjzIfK@debian.me>
Date: Mon, 19 Dec 2022 14:41:07 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Li zeming <zeming@...china.com>, mchehab@...nel.org,
hverkuil-cisco@...all.nl, nicolas.dufresne@...labora.com
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] v4l2-core: v4l2-h264: check after increasing memory
allocation
On Mon, Dec 19, 2022 at 11:37:12AM +0800, Li zeming wrote:
> The pointer *out_str adds judgment and should help with program robustness.
>
Terminology: if[-else] blocks are conditionals, not judgements.
> diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-core/v4l2-h264.c
> index 72bd64f65198..934aba539332 100644
> --- a/drivers/media/v4l2-core/v4l2-h264.c
> +++ b/drivers/media/v4l2-core/v4l2-h264.c
> @@ -305,6 +305,8 @@ static const char *format_ref_list_p(const struct v4l2_h264_reflist_builder *bui
> int n = 0, i;
>
> *out_str = kmalloc(tmp_str_size, GFP_KERNEL);
> + if (!*out_str)
> + return NULL;
Why did you add the check beside robustness?
Thanks.
--
An old man doll... just what I always wanted! - Clara
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists