linux-kernel - RE: [PATCH v1] usb: core: hub: disable autosuspend for TI TUSB8041

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2022 09:49:43 +0000
From:   Flavio Suligoi <f.suligoi@...m.it>
To:     Alan Stern <stern@...land.harvard.edu>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Ray Chi <raychi@...gle.com>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@...tor.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1] usb: core: hub: disable autosuspend for TI TUSB8041

HI Alan,

...

drivers/usb/core/hub.c index
> > 77e73fc8d673..b64be35e203f 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -44,6 +44,10 @@
> >  #define USB_PRODUCT_USB5534B			0x5534
> >  #define USB_VENDOR_CYPRESS			0x04b4
> >  #define USB_PRODUCT_CY7C65632			0x6570
> > +#define USB_VENDOR_TEXAS_INSTRUMENTS		0x0451
> > +#define USB_PRODUCT_TUSB8041_USB3		0x8140
> > +#define USB_PRODUCT_TUSB8041_USB2		\
> > +	(USB_PRODUCT_TUSB8041_USB3 |
> ((USB_PRODUCT_TUSB8041_USB3 & 0x00FF) ^
> > +0x02))
> 
> Argh.  Just put the actual hex number here -- people don't want to do
> calculations like this in their head when they are reading code.  (Not to
> mention that the number would occupy only six characters of source text
> whereas your calculation occupies a lot more.)
> 
> Otherwise fine.

Ok, I'll put the actual hex number instead of the formula.
Thanks for your suggestion!

> 
> Alan Stern
> 

Best regards,
Flavio