linux-kernel - Re: [PATCH] mm: remove unused alloc_pages_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221219100734.jag6zejp4tug77yq@techsingularity.net>
Date:   Mon, 19 Dec 2022 10:07:34 +0000
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Lorenzo Stoakes <lstoakes@...il.com>
Cc:     Matthew Wilcox <willy@...radead.org>, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Andrey Konovalov <andreyknvl@...il.com>,
        Ingo Molnar <mingo@...nel.org>, Marco Elver <elver@...gle.com>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list()

On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote:
> + Mel
> 
> On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote:
> > I think we're waiting to see if any users show up.  It's only been 18
> > months or so, so perhaps wait a little longer?
> 
> Apologies, I should have researched the background of this further. I see it was
> added speculatively in 0f87d9d30f.
> 
> > Also, if we do get rid of this, then __alloc_pages_bulk() can lose
> > the "list" argument.
> 
> Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage,
> otherwise we can drop the idea and wait for users to emerge.

I reckon we should give it another few months until May. There has been
one user recently that tried to use list but it turned out arrays were
more appropriate.

-- 
Mel Gorman
SUSE Labs