linux-kernel - Re: [PATCH] mmc: sdhci-sprd: disable polling scan for sdio card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <852db20c-7913-bb6a-8019-b02d07241960@intel.com>
Date:   Mon, 19 Dec 2022 12:36:06 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Wenchao Chen <wenchao.chen@...soc.com>, ulf.hansson@...aro.org,
        orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhenxiong.lai@...soc.com, yuelin.tang@...soc.com,
        wenchao.chen666@...il.com
Subject: Re: [PATCH] mmc: sdhci-sprd: disable polling scan for sdio card

On 19/12/22 10:47, Wenchao Chen wrote:
> Enable polling will increase the power consumption of the host.
> 
> Fixes: fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
> Signed-off-by: Wenchao Chen <wenchao.chen@...soc.com>
> ---
>  drivers/mmc/host/sdhci-sprd.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 525f979e2a97..113a5c77578f 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -696,6 +696,10 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_cleanup_host;
>  
> +	if ((host->mmc->caps2 & MMC_CAP2_NO_SD) &&
> +			(host->mmc->caps2 & MMC_CAP2_NO_MMC))
> +		host->mmc->caps &= ~MMC_CAP_NEEDS_POLL;

How is MMC_CAP_NEEDS_POLL getting set? SDHCI won't set it for
non-removable cards.  Is it removable?

> +
>  	pm_runtime_mark_last_busy(&pdev->dev);
>  	pm_runtime_put_autosuspend(&pdev->dev);
>