[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c906603f-bf84-06d4-3e9c-bd4ab748591d@linaro.org>
Date: Mon, 19 Dec 2022 11:44:42 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Xingyu Wu <xingyu.wu@...rfivetech.com>,
linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
linux-watchdog@...r.kernel.org,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Philipp Zabel <p.zabel@...gutronix.de>,
Samin Guo <samin.guo@...rfivetech.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: watchdog: Add watchdog for StarFive
JH7110
On 19/12/2022 10:42, Xingyu Wu wrote:
> Add bindings to describe the watchdog for the StarFive JH7110 SoC.
>
> Signed-off-by: Xingyu Wu <xingyu.wu@...rfivetech.com>
> ---
> .../watchdog/starfive,jh7110-wdt.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
> new file mode 100644
> index 000000000000..a7bfe0751928
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/starfive,jh7110-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive Watchdog
> +
> +maintainers:
> + - Samin Guo <samin.guo@...rfivetech.com>
> + - Xingyu Wu <xingyu.wu@...rfivetech.com>
> +
You miss watchdog.yaml. I asked to drop the quotes (so the " character),
not the $ref. Please keep the $ref: watchdog.yaml and use
unevaluatedProperties at the end (instead of additionalProperties).
Best regards,
Krzysztof
Powered by blists - more mailing lists