linux-kernel - Re: [PATCH v16 2/3] dt-bindings: edac: nuvoton: Add document for NPCM memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2022 20:18:25 +0800
From:   Kun-Fa Lin <milkfafa@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     linux-edac@...r.kernel.org, rric@...nel.org, james.morse@....com,
        tony.luck@...el.com, mchehab@...nel.org, bp@...en8.de,
        robh+dt@...nel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
        benjaminfair@...gle.com, yuenn@...gle.com, venture@...gle.com,
        KWLIU@...oton.com, YSCHU@...oton.com, avifishman70@...il.com,
        tmaimon77@...il.com, tali.perry1@...il.com, ctcchien@...oton.com,
        kflin@...oton.com, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v16 2/3] dt-bindings: edac: nuvoton: Add document for NPCM
 memory controller

Hi Krzysztof,

Thanks for the review.

> > So this is a 16th version but through this entire year you never Cced
> > the maintainers... You did not send a single version to the memory
> > controller maintainers.
> >
> > I don't know why it is so big problem to use scripts/get_maintainers.pl.
>
> Although maybe the reason for this is that it was being put in edac
> directory... eh...

I should check the CC list for each version anyway. I'm sorry about that.

> > +++ b/Documentation/devicetree/bindings/memory-controllers/nuvoton,npcm-mc.yaml
>
> filename based on compatibles, so nuvoton,npcm-memory-controller.yaml

> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +
>
> No blank lines.

> > +    ahb {
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
>
> Why do you need this node in the example?

These problems will be addressed in next patch. Thank you.

Regards,
Marvin