linux-kernel - Re: [PATCH] [Backport for 4.14] perf script python: Remove explicit shebang from tests/attr.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <617a746a-5f64-6d7c-48df-7c96b3aca535@csgroup.eu>
Date:   Mon, 19 Dec 2022 12:21:47 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     FRANJOU Stephane <stephane.franjou@...roup.eu>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        Tony Jones <tonyj@...e.de>, Jiri Olsa <jolsa@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] [Backport for 4.14] perf script python: Remove explicit
 shebang from tests/attr.c



Le 19/12/2022 à 13:18, Greg KH a écrit :
> On Fri, Dec 16, 2022 at 12:38:12PM +0100, Christophe Leroy wrote:
>> From: Tony Jones <tonyj@...e.de>
>>
>> [Upstream commit d72eadbc1d2866fc047edd4535ffb0298fe240be]
>>
>> tests/attr.c invokes attr.py via an explicit invocation of Python
>> ($PYTHON) so there is therefore no need for an explicit shebang.
>>
>> Also most distros follow pep-0394 which recommends that /usr/bin/python
>> refer only to v2 and so may not exist on the system (if PYTHON=python3).
>>
>> Signed-off-by: Tony Jones <tonyj@...e.de>
>> Acked-by: Jiri Olsa <jolsa@...nel.org>
>> Cc: Jonathan Corbet <corbet@....net>
>> Cc: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
>> Cc: Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>
>> Link: http://lkml.kernel.org/r/20190124005229.16146-5-tonyj@suse.de
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
>> ---
>>   tools/perf/tests/attr.py | 1 -
>>   1 file changed, 1 deletion(-)
> 
> Why only 4.14?  What about 4.19?
> 


I submitted that backport because I encountered the problem while 
building perf for 4.14.

I didn't look at other kernel versions.

Christophe