linux-kernel - Re: [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y6BYRDbprdAeE0IZ@lucifer>
Date:   Mon, 19 Dec 2022 12:25:40 +0000
From:   Lorenzo Stoakes <lstoakes@...il.com>
To:     Uladzislau Rezki <urezki@...il.com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in
 __vmalloc_area_node()

On Mon, Dec 19, 2022 at 01:09:41PM +0100, Uladzislau Rezki wrote:
> There are three more warn_alloc()s below. Those are explicitly disabled.
> Could you please rework the patch and make it working also?

Ah yes, sorry missed those, I think then the simplest solution then would be to
simply yank the __GFP_NOWARN specifier at the top of the function and restore
the explicit flag being passed to vm_area_alloc_pages() you added in
c3d77172dfc0.

This whole thing does make me wonder if this function is due a more general
refactor.

Will spin up a v2!