[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221219123659.90614-1-lstoakes@gmail.com>
Date: Mon, 19 Dec 2022 12:36:59 +0000
From: Lorenzo Stoakes <lstoakes@...il.com>
To: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
Uladzislau Rezki <urezki@...il.com>,
Christoph Hellwig <hch@...radead.org>,
linux-kernel@...r.kernel.org
Cc: Matthew Wilcox <willy@...radead.org>,
Nicholas Piggin <npiggin@...il.com>,
Baoquan He <bhe@...hat.com>,
Lorenzo Stoakes <lstoakes@...il.com>
Subject: [PATCH v2] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node()
This function sets __GFP_NOWARN in the gfp_mask rendering the warn_alloc()
invocations no-ops. Remove this and instead rely on this flag being set
only for the vm_area_alloc_pages() function, ensuring it is cleared for
each of the warn_alloc() calls.
Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index ca71de7c9d77..10fe83c24436 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3031,7 +3031,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
int ret;
array_size = (unsigned long)nr_small_pages * sizeof(struct page *);
- gfp_mask |= __GFP_NOWARN;
+
if (!(gfp_mask & (GFP_DMA | GFP_DMA32)))
gfp_mask |= __GFP_HIGHMEM;
--
2.39.0
Powered by blists - more mailing lists