linux-kernel - Re: [PATCH] drm: Replace DRM_INFO() with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1852b054022.16e87c6b116450.6116081892972417758@siddh.me>
Date:   Mon, 19 Dec 2022 21:04:02 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     "Thomas Zimmermann" <tzimmermann@...e.de>
Cc:     "maarten lankhorst" <maarten.lankhorst@...ux.intel.com>,
        "maxime ripard" <mripard@...nel.org>,
        "david airlie" <airlied@...il.com>,
        "daniel vetter" <daniel@...ll.ch>,
        "dri-devel" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: Replace DRM_INFO() with pr_info()

On Mon, 19 Dec 2022 20:27:45 +0530, Thomas Zimmermann wrote:
> Hi
> 
> Am 19.12.22 um 15:23 schrieb Siddh Raman Pant:
> > Line 536 of drm_print.h says DRM_INFO() is deprecated
> > in favor of pr_info().
> 
> That's a misleading comment. DRM_INFO() is deprecated for drm_info(). 
> pr_info() et al is only to be used of you don't have a dev pointer.
> 
> Best regards
> Thomas

Maybe you are confusing it with DRM_DEV_INFO? It takes the dev pointer,
and is indeed told to be deprecated in favour of drm_info() in the
comments (see line 394).

DRM_INFO is a separate macro for printing stuff, and does not take the
dev pointer. They seem to be early wrappers for printk, I guess when
pr_info did not exist. And all they do different from pr_info is to add
DRM_NAME (which seems to be just "drm") in front of the string.

Thanks,
Siddh