linux-kernel - Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221219112542.fb30929b8b91255dcba5a289@hugovil.com>
Date:   Mon, 19 Dec 2022 11:25:42 -0500
From:   Hugo Villeneuve <hugo@...ovil.com>
To:     Bruno Thomsen <bruno.thomsen@...il.com>
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

On Mon, 19 Dec 2022 10:14:10 +0100
Bruno Thomsen <bruno.thomsen@...il.com> wrote:

> Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <hugo@...ovil.com>:
> >
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> >
> > Add support for new NXP RTC PCF2131.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > ---
> >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..a8f8c23da4d8 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,9 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    const: nxp,pcf2127
> > +    enum:
> > +      - nxp,pcf2127
> > +      - nxp,pcf2131
> 
> The enum is incomplete as pcf2127_of_match struct also contains:
> nxp,pcf2129
> ncp,pca2129
> 
> /Bruno

Hi,
if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...

Hugo.


> >    reg:
> >      maxItems: 1
> > --
> > 2.30.2
> >
> 


-- 
Hugo Villeneuve <hugo@...ovil.com>