linux-kernel - Re: [PATCH 5/5] drivers: mmc: sdhci-cadence: Add debug option for sdhci-cadence driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 20 Dec 2022 01:14:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Piyush Malgujar <pmalgujar@...vell.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, adrian.hunter@...el.com,
        ulf.hansson@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, yamada.masahiro@...ionext.com,
        devicetree@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, jannadurai@...vell.com,
        cchavva@...vell.com, Piyush Malgujar <pmalgujar@...vell.com>
Subject: Re: [PATCH 5/5] drivers: mmc: sdhci-cadence: Add debug option for
 sdhci-cadence driver.

Hi Piyush,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.1 next-20221219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Piyush-Malgujar/drivers-mmc-sdhci-cadence-SD6-controller-support/20221219-222703
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20221219142418.27949-6-pmalgujar%40marvell.com
patch subject: [PATCH 5/5] drivers: mmc: sdhci-cadence: Add debug option for sdhci-cadence driver.
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2f50d93c62815502509f88632801e0d3e68600d1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Piyush-Malgujar/drivers-mmc-sdhci-cadence-SD6-controller-support/20221219-222703
        git checkout 2f50d93c62815502509f88632801e0d3e68600d1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/mmc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/mmc/host/sdhci-cadence.c:1026:6: warning: no previous prototype for 'sdhci_cdns_sd6_dump' [-Wmissing-prototypes]
    1026 | void sdhci_cdns_sd6_dump(struct sdhci_cdns_priv *priv)
         |      ^~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MMC_SDHCI_IO_ACCESSORS
   Depends on [n]: MMC [=m] && MMC_SDHCI [=n]
   Selected by [m]:
   - MMC_SDHCI_CN10K [=m] && MMC [=m]
   WARNING: unmet direct dependencies detected for MMC_SDHCI_CADENCE
   Depends on [n]: MMC [=m] && MMC_SDHCI_PLTFM [=n] && OF [=y]
   Selected by [m]:
   - MMC_SDHCI_CN10K [=m] && MMC [=m]


vim +/sdhci_cdns_sd6_dump +1026 drivers/mmc/host/sdhci-cadence.c

  1025	
> 1026	void sdhci_cdns_sd6_dump(struct sdhci_cdns_priv *priv)
  1027	{
  1028		struct sdhci_cdns_sd6_phy *phy = priv->phy;
  1029		int id;
  1030	
  1031		sdhci_cdns_sd6_phy_dump(phy);
  1032	
  1033		DEBUG_DRV("Host controller Register Dump\n");
  1034		for (id = 0; id < 14; id++)
  1035			DEBUG_DRV("HRS%d 0x%x\n", id, readl(priv->hrs_addr + (id * 4)));
  1036	
  1037		id = 29;
  1038		DEBUG_DRV("HRS%d 0x%x\n", id, readl(priv->hrs_addr + (id * 4)));
  1039		id = 30;
  1040		DEBUG_DRV("HRS%d 0x%x\n", id, readl(priv->hrs_addr + (id * 4)));
  1041	
  1042		for (id = 0; id < 27; id++)
  1043			DEBUG_DRV("SRS%d 0x%x\n", id, readl(priv->hrs_addr + 0x200 + (id * 4)));
  1044	
  1045		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DQS_TIMING 0x%x\n",
  1046			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DQS_TIMING));
  1047		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_GATE_LPBK 0x%x\n",
  1048			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_GATE_LPBK));
  1049		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DLL_MASTER 0x%x\n",
  1050			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DLL_MASTER));
  1051		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DLL_SLAVE 0x%x\n",
  1052			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DLL_SLAVE));
  1053		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_CTRL 0x%x\n",
  1054			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_CTRL));
  1055		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_GPIO_CTRL0 0x%x\n",
  1056			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_GPIO_CTRL0));
  1057		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DQ_TIMING 0x%x\n",
  1058			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DQ_TIMING));
  1059		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DLL_OBS_REG0 0x%x\n",
  1060			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DLL_OBS_REG0));
  1061		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DLL_OBS_REG1 0x%x\n",
  1062			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DLL_OBS_REG1));
  1063		DEBUG_DRV("SDHCI_CDNS_SD6_PHY_DLL_OBS_REG2 0x%x\n",
  1064			  sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_DLL_OBS_REG2));
  1065	}
  1066	#endif
  1067	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (244157 bytes)