linux-kernel - Re: [PATCH 3/7] spi: cadence: Add polling mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212200119.QMQ0WM4W-lkp@intel.com>
Date:   Tue, 20 Dec 2022 02:05:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Witold Sadowski <wsadowski@...vell.com>, broonie@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        jpawar@...ence.com, pthombar@...ence.com, konrad@...ence.com,
        wbartczak@...vell.com, wzmuda@...vell.com, wsadowski@...vell.com
Subject: Re: [PATCH 3/7] spi: cadence: Add polling mode support

Hi Witold,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on linus/master v6.1 next-20221219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Witold-Sadowski/Support-for-Marvell-modifications-for-Cadence-XSPI/20221219-224547
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20221219144254.20883-4-wsadowski%40marvell.com
patch subject: [PATCH 3/7] spi: cadence: Add polling mode support
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0607f814dcd1b5b46998036b3488badc995ce4cc
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Witold-Sadowski/Support-for-Marvell-modifications-for-Cadence-XSPI/20221219-224547
        git checkout 0607f814dcd1b5b46998036b3488badc995ce4cc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-cadence-xspi.c:354:6: warning: no previous prototype for 'cdns_xspi_stig_ready' [-Wmissing-prototypes]
     354 | bool cdns_xspi_stig_ready(struct cdns_xspi_dev *cdns_xspi)
         |      ^~~~~~~~~~~~~~~~~~~~
>> drivers/spi/spi-cadence-xspi.c:365:6: warning: no previous prototype for 'cdns_xspi_sdma_ready' [-Wmissing-prototypes]
     365 | bool cdns_xspi_sdma_ready(struct cdns_xspi_dev *cdns_xspi)
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/cdns_xspi_stig_ready +354 drivers/spi/spi-cadence-xspi.c

   353	
 > 354	bool cdns_xspi_stig_ready(struct cdns_xspi_dev *cdns_xspi)
   355	{
   356		u32 ctrl_stat;
   357	
   358		return readl_relaxed_poll_timeout
   359			(cdns_xspi->iobase + CDNS_XSPI_CTRL_STATUS_REG,
   360			ctrl_stat,
   361			((ctrl_stat & BIT(3)) == 0),
   362			CDNS_XSPI_POLL_DELAY_US, CDNS_XSPI_POLL_TIMEOUT_US);
   363	}
   364	
 > 365	bool cdns_xspi_sdma_ready(struct cdns_xspi_dev *cdns_xspi)
   366	{
   367		u32 ctrl_stat;
   368	
   369		return readl_relaxed_poll_timeout
   370			(cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG,
   371			ctrl_stat,
   372			(ctrl_stat & CDNS_XSPI_SDMA_TRIGGER),
   373			CDNS_XSPI_POLL_DELAY_US, CDNS_XSPI_POLL_TIMEOUT_US);
   374	}
   375	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (276538 bytes)