linux-kernel - [PATCH v2 5/8] crypto: x86/sm3 - add kernel-doc comments to assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221219185555.433233-6-elliott@hpe.com>
Date:   Mon, 19 Dec 2022 12:55:52 -0600
From:   Robert Elliott <elliott@....com>
To:     herbert@...dor.apana.org.au, davem@...emloft.net, corbet@....net,
        linux-crypto@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Robert Elliott <elliott@....com>
Subject: [PATCH v2 5/8] crypto: x86/sm3 - add kernel-doc comments to assembly

Add kernel-doc comments for assembly language functions exported to
C glue code.

Signed-off-by: Robert Elliott <elliott@....com>
---
 arch/x86/crypto/sm3-avx-asm_64.S | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/crypto/sm3-avx-asm_64.S b/arch/x86/crypto/sm3-avx-asm_64.S
index 503bab450a91..30e51c681c07 100644
--- a/arch/x86/crypto/sm3-avx-asm_64.S
+++ b/arch/x86/crypto/sm3-avx-asm_64.S
@@ -322,18 +322,18 @@
 
 .text
 
-/*
- * Transform nblocks*64 bytes (nblocks*16 32-bit words) at DATA.
+/**
+ * sm3_transform_avx - Calculate SM3 hash using x86 AVX feature set
+ * @state:	address of 32-byte context (%rdi, RSTATE macro)
+ * @data:	address of data            (%rsi, RDATA macro);
+ *		must be at least 64 bytes and a multiple of 64 bytes
+ * @nblocks:	number of 64-byte blocks   (%rdx, RNBLKS macro);
+ *		must be >= 1
  *
- * void sm3_transform_avx(struct sm3_state *state,
- *                        const u8 *data, int nblocks);
+ * Return:	none. However, the @state buffer is updated.
+ * Prototype:	asmlinkage void sm3_transform_avx(u32 *state, const u8 *data, int nblocks);
  */
 SYM_TYPED_FUNC_START(sm3_transform_avx)
-	/* input:
-	 *	%rdi: ctx, CTX
-	 *	%rsi: data (64*nblks bytes)
-	 *	%rdx: nblocks
-	 */
 	vzeroupper;
 
 	pushq %rbp;
-- 
2.38.1