[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y6C4ni3wpkaYxmLw@tycho.pizza>
Date: Mon, 19 Dec 2022 12:16:46 -0700
From: Tycho Andersen <tycho@...ho.pizza>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: Eric Biederman <ebiederm@...ssion.com>,
linux-kernel@...r.kernel.org, fuse-devel@...ts.sourceforge.net,
"Serge E . Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH v3] fuse: In fuse_flush only wait if someone wants the
return code
On Thu, Dec 08, 2022 at 10:49:30AM -0700, Tycho Andersen wrote:
> On Thu, Dec 08, 2022 at 03:26:19PM +0100, Miklos Szeredi wrote:
> > On Mon, 28 Nov 2022 at 16:01, Tycho Andersen <tycho@...ho.pizza> wrote:
> > >
> > > Hi Milkos,
> > >
> > > On Mon, Nov 14, 2022 at 09:02:09AM -0700, Tycho Andersen wrote:
> > > > v3: use schedule_work() to avoid other sleeps in inode_write_now() and
> > > > fuse_sync_writes(). Fix a UAF of the stack-based inarg.
> > >
> > > Thoughts on this version?
> >
> > Skipping attr invalidation on success is wrong.
>
> Agreed, that looks like my mistake.
>
> > How about the attached (untested) patch?
>
> It passes my reproducer with no warnings or anything. Feel free to
> add:
>
> Tested-by: Tycho Andersen <tycho@...ho.pizza>
>
> if you want to commit it.
Ping, thoughts on landing this?
Thanks,
Tycho
Powered by blists - more mailing lists