linux-kernel - Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2022 07:03:49 +0100
From:   Marek Vasut <marex@...x.de>
To:     Hongxing Zhu <hongxing.zhu@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "a.fatoum@...gutronix.de" <a.fatoum@...gutronix.de>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        "richard.leitner@...ux.dev" <richard.leitner@...ux.dev>
Cc:     "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY
 support

On 12/19/22 04:25, Hongxing Zhu wrote:

Hi,

>>> @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct
>> platform_device *pdev)
>>>    		return PTR_ERR(imx8_phy->reset);
>>>    	}
>>>
>>> +	if (imx8_phy->drvdata->variant == IMX8MP) {
>>> +		imx8_phy->perst =
>>> +			devm_reset_control_get_exclusive(dev, "perst");
>>> +		if (IS_ERR(imx8_phy->perst))
>>> +			dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
>>
>> I just notice this , are we missing return here ?
>>
>> That is ... return dev_err_probe(...) ?
> 
> Ooh, it's my fault. Thanks for your reminder.
> One return should be here.
> -                       dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> +                       return dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> Hi Vinod @vkoul@...nel.org:
> Should I re-summit one fix patch?

I think just send a follow up patch with Fixes: tag .