linux-kernel - Re: [PATCH] mm: new primitive kvmemdup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2022 14:29:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hao Sun <sunhao.th@...il.com>, linux-mm@...ck.org,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, daniel@...earbox.net,
        Hao Sun <sunhao.th@...il.com>
Subject: Re: [PATCH] mm: new primitive kvmemdup()

Hi Hao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on f9ff5644bcc04221bae56f922122f2b7f5d24d62]

url:    https://github.com/intel-lab-lkp/linux/commits/Hao-Sun/mm-new-primitive-kvmemdup/20221219-122348
base:   f9ff5644bcc04221bae56f922122f2b7f5d24d62
patch link:    https://lore.kernel.org/r/20221219042126.3396-1-sunhao.th%40gmail.com
patch subject: [PATCH] mm: new primitive kvmemdup()
config: x86_64-rhel-8.3
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/29c8ee8f5f8fcd8f52aa6912bdb55f3dc135b5a0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hao-Sun/mm-new-primitive-kvmemdup/20221219-122348
        git checkout 29c8ee8f5f8fcd8f52aa6912bdb55f3dc135b5a0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> security/apparmor/policy_unpack.c:164:14: error: conflicting types for 'kvmemdup'; have 'void *(const void *, size_t)' {aka 'void *(const void *, long unsigned int)'}
     164 | static void *kvmemdup(const void *src, size_t len)
         |              ^~~~~~~~
   In file included from include/linux/bitmap.h:11,
                    from include/linux/cpumask.h:12,
                    from arch/x86/include/asm/cpumask.h:5,
                    from arch/x86/include/asm/msr.h:11,
                    from arch/x86/include/asm/processor.h:23,
                    from arch/x86/include/asm/cpufeature.h:5,
                    from arch/x86/include/asm/thread_info.h:53,
                    from include/linux/thread_info.h:60,
                    from arch/x86/include/asm/preempt.h:9,
                    from include/linux/preempt.h:78,
                    from include/linux/rcupdate.h:27,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/audit.h:12,
                    from security/apparmor/include/audit.h:14,
                    from security/apparmor/policy_unpack.c:23:
   include/linux/string.h:180:14: note: previous declaration of 'kvmemdup' with type 'void *(const void *, size_t,  gfp_t)' {aka 'void *(const void *, long unsigned int,  unsigned int)'}
     180 | extern void *kvmemdup(const void *src, size_t len, gfp_t gfp) __realloc_size(2);
         |              ^~~~~~~~


vim +164 security/apparmor/policy_unpack.c

736ec752d95e91 John Johansen   2010-07-29  163  
8e51f9087f4024 Matthew Garrett 2018-02-08 @164  static void *kvmemdup(const void *src, size_t len)
8e51f9087f4024 Matthew Garrett 2018-02-08  165  {
8e51f9087f4024 Matthew Garrett 2018-02-08  166  	void *p = kvmalloc(len, GFP_KERNEL);
8e51f9087f4024 Matthew Garrett 2018-02-08  167  
8e51f9087f4024 Matthew Garrett 2018-02-08  168  	if (p)
8e51f9087f4024 Matthew Garrett 2018-02-08  169  		memcpy(p, src, len);
8e51f9087f4024 Matthew Garrett 2018-02-08  170  	return p;
8e51f9087f4024 Matthew Garrett 2018-02-08  171  }
8e51f9087f4024 Matthew Garrett 2018-02-08  172  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (166886 bytes)