linux-kernel - Re: [PATCH v5] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <383225a2-0430-03d7-4e6b-e2bfb2d76fe5@quicinc.com>
Date:   Mon, 19 Dec 2022 16:24:41 -0600
From:   Melody Olvera <quic_molvera@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC:     "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for
 generic nodes



On 12/17/2022 8:29 AM, Konrad Dybcio wrote:
>
> On 17.12.2022 00:13, Melody Olvera wrote:
>> Update the bindings to allow for generic regulator nodes instead of
>> device-specific node names.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>> ---
>>
>> Changes from v4:
>> * updated regulator pattern to accommodate more regulators
>>
>> This patch comes from discussions on [1] and is separated out. It also
>> has updated pattern matching to match the comments left from [1].
>>
>> [1] https://lore.kernel.org/all/20221026200429.162212-2-quic_molvera@quicinc.com/
>>
>> ---
>>  Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
>> index b246500d3d5d..5bb624f62edc 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
>> @@ -112,8 +112,9 @@ properties:
>>      $ref: /schemas/power/qcom,rpmpd.yaml#
>>  
>>  patternProperties:
>> -  '-regulators$':
>> +  '^regulators(-[09])?$':
> Wouldn't this only allow regulators-0 and regulators-9?

Yup; my bad. Will update regex here.

Thanks,
Melody

>
> Konrad
>>      $ref: /schemas/regulator/qcom,rpmh-regulator.yaml#
>> +    unevaluatedProperties: false
>>  
>>  required:
>>    - compatible
>>
>> base-commit: ca39c4daa6f7f770b1329ffb46f1e4a6bcc3f291