linux-kernel - Re: [PATCH] selftests: Add missing <sys/syscall.h> to mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9e1390c5-844c-9fa5-693e-da9d10c64e21@siddh.me>
Date:   Wed, 21 Dec 2022 02:01:04 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     Daan De Meyer <daan.j.demeyer@...il.com>
Cc:     Christian Brauner <brauner@...nel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-kselftests <linux-kselftest@...r.kernel.org>,
        Seth Forshee <sforshee@...nel.org>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: Add missing <sys/syscall.h> to mount_setattr
 test

On Thu, Dec 01 2022 at 20:32:18 +0530, Daan De Meyer wrote:
> Including <sys/syscall.h> is required to define __NR_mount_setattr
> and __NR_open_tree which the mount_setattr test relies on.
> 
> Signed-off-by: Daan De Meyer <daan.j.demeyer@...il.com>
> ---
>  tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> index 8c5fea68ae67..da85f8af482c 100644
> --- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> +++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> @@ -11,6 +11,7 @@
>  #include <sys/wait.h>
>  #include <sys/vfs.h>
>  #include <sys/statvfs.h>
> +#include <sys/syscall.h>
>  #include <sys/sysinfo.h>
>  #include <stdlib.h>
>  #include <unistd.h>

Tested-by: Siddh Raman Pant <code@...dh.me>

Though this oversight actually led to gcc detecting another
another error [1], as it entered the #ifndef __NR_mount_setattr
block.

Thanks,
Siddh

[1] https://lore.kernel.org/all/20221211092820.85527-1-code@siddh.me/