[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8fb7c0ac-a51d-7d7f-a6e5-791923b6f95a@nvidia.com>
Date: Tue, 20 Dec 2022 22:56:55 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: "Michael S. Tsirkin" <mst@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Jens Axboe <axboe@...nel.dk>,
"virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
Stefan Hajnoczi <stefanha@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH] virtio_blk: temporary variable type tweak
On 12/20/22 04:41, Michael S. Tsirkin wrote:
> virtblk_result returns blk_status_t which is a bitwise restricted type,
> so we are not supposed to stuff it in a plain int temporary variable.
> All we do with it is pass it on to a function expecting blk_status_t so
> the generated code is ok, but we get warnings from sparse:
>
> drivers/block/virtio_blk.c:326:36: sparse: sparse: incorrect type in initializer (different base types) @@ expected int status @@
> +got restricted blk_status_t @@
> drivers/block/virtio_blk.c:334:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted
> +blk_status_t [usertype] error @@ got int status @@
>
> Make sparse happy by using the correct type.
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
-ck
Powered by blists - more mailing lists