linux-kernel - Re: [PATCH] HID: uclogic: Add support for recent Huion tablets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR20MB4953704646AA47DCD3F1DF52BBEA9@IA1PR20MB4953.namprd20.prod.outlook.com>
Date:   Wed, 21 Dec 2022 07:47:50 +0800
From:   Inochi Amaoto <inochiama@...look.com>
To:     jikos@...nel.org, benjamin.tissoires@...hat.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Inochi Amaoto <inochiama@...look.com>
Subject: Re: [PATCH] HID: uclogic: Add support for recent Huion tablets

> While this patch is correct, HUION always reuse the same vendor/product 
> IDs, meaning that it'll affect a fairly big number of devices.

Yes, I agree. Not only recent devices are affected, but old devices with 
new firmware are also affected. [1] shows a firmware update can cause a 
new device id. It seems that HUION just uses new device id for new 
firmware, with nothing changed.

> Checking some comments in DIGImend's issue tracker [1], users report
> that their tablet works applying a similar patch. However, I think that 
> it could be a good idea if you could build a version of the driver
> including your patch and request them to test it.
> 
> I'm pretty sure it'll work, but it might be a good idea to test it on
> more devices before merging it.

That's sure. I have checked DIGImend's issue before submitting this patch.
There is also a pull request to provide the same functionality [2]. And 
the [2] says at least Gaomon M6 and Gaomon 1060pro worked. issue [3] and 
[4] seems to show that H580X and H1161 also works.

Nowadays I am working on my KD200, which is a typical devices of recent 
Huion tablets. This tablets has 3 usbif, so it is not fully recognized in 
the init process of the huion tablets in the kernel. This problem is also 
present in the 0x006d device (with invalid interface) [5]. I think it's OK
to delay this patch and do more test until the invalid interface problem 
is mitigated or solved.  

[1] https://github.com/DIGImend/digimend-kernel-drivers/issues/613
[2] https://github.com/DIGImend/digimend-kernel-drivers/pull/623
[3] https://github.com/DIGImend/digimend-kernel-drivers/issues/600
[4] https://github.com/DIGImend/digimend-kernel-drivers/issues/640
[5] https://github.com/DIGImend/digimend-kernel-drivers/issues?q=interface+is+invalid%2C+ignoring