linux-kernel - Re: [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221220235246.GA2334024@hori.linux.bs1.fc.nec.co.jp>
Date:   Tue, 20 Dec 2022 23:53:11 +0000
From:   HORIGUCHI NAOYA(堀口　直也) 
        <naoya.horiguchi@....com>
To:     Hyeonggon Yoo <42.hyeyoo@...il.com>
CC:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Joe Perches <joe@...ches.com>, Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Matthew WilCox <willy@...radead.org>,
        David Hildenbrand <david@...hat.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from
 action_page_types

On Sun, Dec 18, 2022 at 07:18:58PM +0900, Hyeonggon Yoo wrote:
> As suggested by Naoya [1], identify_page_state() is never
> called when handling memory error on a slab page.
> 
> Clean this up before moving PG_slab flag to page_type in later patch.
> 
> [1] https://lore.kernel.org/linux-mm/Y2s+dnBsHAJu19ob@hyeyoo/#r
> 
> Suggested-by: Naoya Horiguchi <naoya.horiguchi@....com>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@...il.com>

Thank you for the patch,
I think there're a few other places to remove under include/.

  $ grep -inr MF_MSG_SLA include
  include/ras/ras_event.h:359:    EM ( MF_MSG_SLAB, "kernel slab page" )                          \
  include/linux/mm.h:3502:        MF_MSG_SLAB,

, so could you update them together?

Thanks,
Naoya Horiguchi