| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202212201921.kJwfMID1-lkp@intel.com>
Date: Tue, 20 Dec 2022 19:30:01 +0800
From: kernel test robot <lkp@...el.com>
To: Lewis Huang <Lewis.Huang@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Alex Deucher <alexander.deucher@....com>,
Wenjing Liu <Wenjing.Liu@....com>
Subject: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5044:24:
warning: implicit conversion from 'enum <anonymous>' to 'enum dc_status'
Hi Lewis,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6feb57c2fd7c787aecf2846a535248899e7b70fa
commit: b473bd5fc333ab02479444dd4a51be5f5e324d97 drm/amd/display: refine wake up aux in retrieve link caps
date: 8 weeks ago
config: microblaze-randconfig-r005-20221218
compiler: microblaze-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b473bd5fc333ab02479444dd4a51be5f5e324d97
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout b473bd5fc333ab02479444dd4a51be5f5e324d97
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5044:24: warning: implicit conversion from 'enum <anonymous>' to 'enum dc_status' [-Wenum-conversion]
5044 | return false;
| ^~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: At top level:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5230:16: warning: no previous prototype for 'wake_up_aux_channel' [-Wmissing-prototypes]
5230 | enum dc_status wake_up_aux_channel(struct dc_link *link)
| ^~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/resource.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:31:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:137:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
137 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:134:17: warning: 'DP_SINK_BRANCH_DEV_NAME_7580' defined but not used [-Wunused-const-variable=]
134 | static const u8 DP_SINK_BRANCH_DEV_NAME_7580[] = "7580\x80u";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:132:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
132 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
131 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3};
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +5044 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c
96577cf82a1331 Hersen Wu 2020-01-14 5033
b473bd5fc333ab Lewis Huang 2022-10-20 5034 enum dc_status dp_retrieve_lttpr_cap(struct dc_link *link)
77361ed89a8b03 Jimmy Kizito 2022-03-24 5035 {
77361ed89a8b03 Jimmy Kizito 2022-03-24 5036 uint8_t lttpr_dpcd_data[8];
77361ed89a8b03 Jimmy Kizito 2022-03-24 5037 enum dc_status status = DC_ERROR_UNEXPECTED;
77361ed89a8b03 Jimmy Kizito 2022-03-24 5038 bool is_lttpr_present = false;
77361ed89a8b03 Jimmy Kizito 2022-03-24 5039
e844cc250f33d2 Michael Strauss 2022-07-25 5040 /* Logic to determine LTTPR support*/
e844cc250f33d2 Michael Strauss 2022-07-25 5041 bool vbios_lttpr_interop = link->dc->caps.vbios_lttpr_aware;
0bbd1c7de319ca George Shen 2022-01-31 5042
e844cc250f33d2 Michael Strauss 2022-07-25 5043 if (!vbios_lttpr_interop || !link->dc->caps.extended_aux_timeout_support)
e844cc250f33d2 Michael Strauss 2022-07-25 @5044 return false;
0bbd1c7de319ca George Shen 2022-01-31 5045
c797ede0ec89f1 Wenjing Liu 2020-06-01 5046 /* By reading LTTPR capability, RX assumes that we will enable
7809fc00e20e6e Wesley Chalmers 2021-03-17 5047 * LTTPR extended aux timeout if LTTPR is present.
c797ede0ec89f1 Wenjing Liu 2020-06-01 5048 */
e844cc250f33d2 Michael Strauss 2022-07-25 5049 status = core_link_read_dpcd(link,
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5050 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV,
4d1d699f479dc8 Michael Strauss 2022-05-06 5051 lttpr_dpcd_data,
4d1d699f479dc8 Michael Strauss 2022-05-06 5052 sizeof(lttpr_dpcd_data));
3b90318d44f87a Michael Strauss 2022-04-22 5053
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5054 link->dpcd_caps.lttpr_caps.revision.raw =
4d1d699f479dc8 Michael Strauss 2022-05-06 5055 lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5056 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
8e5100a575433c abdoulaye berthe 2019-07-19 5057
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5058 link->dpcd_caps.lttpr_caps.max_link_rate =
4d1d699f479dc8 Michael Strauss 2022-05-06 5059 lttpr_dpcd_data[DP_MAX_LINK_RATE_PHY_REPEATER -
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5060 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
8e5100a575433c abdoulaye berthe 2019-07-19 5061
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5062 link->dpcd_caps.lttpr_caps.phy_repeater_cnt =
4d1d699f479dc8 Michael Strauss 2022-05-06 5063 lttpr_dpcd_data[DP_PHY_REPEATER_CNT -
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5064 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
8e5100a575433c abdoulaye berthe 2019-07-19 5065
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5066 link->dpcd_caps.lttpr_caps.max_lane_count =
4d1d699f479dc8 Michael Strauss 2022-05-06 5067 lttpr_dpcd_data[DP_MAX_LANE_COUNT_PHY_REPEATER -
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5068 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
8e5100a575433c abdoulaye berthe 2019-07-19 5069
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5070 link->dpcd_caps.lttpr_caps.mode =
4d1d699f479dc8 Michael Strauss 2022-05-06 5071 lttpr_dpcd_data[DP_PHY_REPEATER_MODE -
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5072 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
8e5100a575433c abdoulaye berthe 2019-07-19 5073
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5074 link->dpcd_caps.lttpr_caps.max_ext_timeout =
4d1d699f479dc8 Michael Strauss 2022-05-06 5075 lttpr_dpcd_data[DP_PHY_REPEATER_EXTENDED_WAIT_TIMEOUT -
61aa7a6f760e78 abdoulaye berthe 2019-10-10 5076 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
f01ee019586220 Fangzhi Zuo 2021-08-03 5077 link->dpcd_caps.lttpr_caps.main_link_channel_coding.raw =
4d1d699f479dc8 Michael Strauss 2022-05-06 5078 lttpr_dpcd_data[DP_MAIN_LINK_CHANNEL_CODING_PHY_REPEATER -
f01ee019586220 Fangzhi Zuo 2021-08-03 5079 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
f01ee019586220 Fangzhi Zuo 2021-08-03 5080
f01ee019586220 Fangzhi Zuo 2021-08-03 5081 link->dpcd_caps.lttpr_caps.supported_128b_132b_rates.raw =
4d1d699f479dc8 Michael Strauss 2022-05-06 5082 lttpr_dpcd_data[DP_PHY_REPEATER_128B132B_RATES -
f01ee019586220 Fangzhi Zuo 2021-08-03 5083 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
f01ee019586220 Fangzhi Zuo 2021-08-03 5084
47c2790ad69d1f Michael Strauss 2022-08-31 5085 /* If this chip cap is set, at least one retimer must exist in the chain
e844cc250f33d2 Michael Strauss 2022-07-25 5086 * Override count to 1 if we receive a known bad count (0 or an invalid value)
e844cc250f33d2 Michael Strauss 2022-07-25 5087 */
47c2790ad69d1f Michael Strauss 2022-08-31 5088 if (link->chip_caps & EXT_DISPLAY_PATH_CAPS__DP_FIXED_VS_EN &&
47c2790ad69d1f Michael Strauss 2022-08-31 5089 (dp_convert_to_count(link->dpcd_caps.lttpr_caps.phy_repeater_cnt) == 0)) {
47c2790ad69d1f Michael Strauss 2022-08-31 5090 ASSERT(0);
47c2790ad69d1f Michael Strauss 2022-08-31 5091 link->dpcd_caps.lttpr_caps.phy_repeater_cnt = 0x80;
345d6493476615 Leo Chen 2022-09-16 5092 DC_LOG_DC("lttpr_caps forced phy_repeater_cnt = %d\n", link->dpcd_caps.lttpr_caps.phy_repeater_cnt);
47c2790ad69d1f Michael Strauss 2022-08-31 5093 }
47c2790ad69d1f Michael Strauss 2022-08-31 5094
ede4f6dac99e4b Jimmy Kizito 2021-04-05 5095 /* Attempt to train in LTTPR transparent mode if repeater count exceeds 8. */
e844cc250f33d2 Michael Strauss 2022-07-25 5096 is_lttpr_present = dp_is_lttpr_present(link);
e844cc250f33d2 Michael Strauss 2022-07-25 5097
e844cc250f33d2 Michael Strauss 2022-07-25 5098 if (is_lttpr_present)
e844cc250f33d2 Michael Strauss 2022-07-25 5099 CONN_DATA_DETECT(link, lttpr_dpcd_data, sizeof(lttpr_dpcd_data), "LTTPR Caps: ");
e844cc250f33d2 Michael Strauss 2022-07-25 5100
345d6493476615 Leo Chen 2022-09-16 5101 DC_LOG_DC("is_lttpr_present = %d\n", is_lttpr_present);
b473bd5fc333ab Lewis Huang 2022-10-20 5102 return status;
e844cc250f33d2 Michael Strauss 2022-07-25 5103 }
e844cc250f33d2 Michael Strauss 2022-07-25 5104
:::::: The code at line 5044 was first introduced by commit
:::::: e844cc250f33d207077d0af9337484d6c94048f0 drm/amd/display: Refactor LTTPR mode selection
:::::: TO: Michael Strauss <michael.strauss@....com>
:::::: CC: Alex Deucher <alexander.deucher@....com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (136169 bytes)
Powered by blists - more mailing lists