linux-kernel - Re: [PATCH] soc: mediatek: mtk-svs: Enable the IRQ later

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52fb6ccf3fe1cb11f3e330ecc4d9c6cf1225c98a.camel@mediatek.com>
Date:   Tue, 20 Dec 2022 11:03:36 +0000
From:   Roger Lu (陸瑞傑) <Roger.Lu@...iatek.com>
To:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "ribalda@...omium.org" <ribalda@...omium.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] soc: mediatek: mtk-svs: Enable the IRQ later

Hi Matthias Sir,

After applying this patch, SVS probes fail as below on my MT8192 platform. If
thing isn't too late, please do not merge this patch. I'll ask Ricardo how to
reproduce this issue and give the correct solution. Thanks in advance.

#MT8192 platform SVS probe fail log
[   10.209430]  SVSB_GPU_LOW: init02 completion timeout
[   10.214402] mtk-svs 1100b000.svs: svs start fail: -16
[   10.219479] mtk-svs: probe of 1100b000.svs failed with error -16

Hi Ricardo,

Could you share us how you reproduce this issue? I have MT8192 Chromebook and
can give it a try to reproduce the issue you encountered. Thanks a lot.

Sincerely,
Roger Lu.

On Fri, 2022-12-16 at 13:47 +0100, Matthias Brugger wrote:
> 
> On 30/11/2022 12:00, AngeloGioacchino Del Regno wrote:
> > Il 27/11/22 21:22, Ricardo Ribalda ha scritto:
> > > If the system does not come from reset (like when is booted via
> > > kexec()), the peripheral might triger an IRQ before the data structures
> > > are initialised.
> > > 
> > > Fixes:
> > > 
> > > [    0.227710] Unable to handle kernel NULL pointer dereference at
> > > virtual 
> > > address 0000000000000f08
> > > [    0.227913] Call trace:
> > > [    0.227918]  svs_isr+0x8c/0x538
> > > 
> > > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> > 
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > 
> > 
> 
> Applied thanks!
>