linux-kernel - Re: [PATCH] mtd: cfi: allow building spi-intel standalone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <b543cdaa-f880-4413-bdb0-80e9a94d03c4@app.fastmail.com>
Date:   Tue, 20 Dec 2022 15:41:25 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Tudor Ambarus" <tudor.ambarus@...aro.org>,
        "Tokunori Ikegami" <ikegami.t@...il.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Miquel Raynal" <miquel.raynal@...tlin.com>,
        "Richard Weinberger" <richard@....at>,
        "Vignesh Raghavendra" <vigneshr@...com>
Cc:     "Lee Jones" <lee.jones@...aro.org>,
        "Mauro Lima" <mauro.lima@...ypsium.com>,
        "Tudor Ambarus" <tudor.ambarus@...rochip.com>,
        "Mika Westerberg" <mika.westerberg@...ux.intel.com>,
        "Boris Brezillon" <boris.brezillon@...labora.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: cfi: allow building spi-intel standalone

On Tue, Dec 20, 2022, at 06:51, Tudor Ambarus wrote:
> On 19.12.2022 17:12, Tokunori Ikegami wrote:
>> 
>> On 2022/12/16 1:39, Arnd Bergmann wrote:
>>> From: Arnd Bergmann<arnd@...db.de>
>>>
>>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
>>> fails to build, as it includes the shared CFI header:
>> The header file linux/mtd/cfi.h is included by the head file 
>> linux/mtd/spi-nor.h so seems the warning caused.
>> Is it really necessary to inculude linux/mtd/cfi.h from 
>> linux/mtd/spi-nor.h?
>> (It seems that it can be resolved the issue by removing the including 
>> cfi.h from spi-nor.h if unnecessary.)
>
> SPI NOR does not depend on CFI. cfi.h shouldn't be included by
> spi-nor.h, indeed.

Right, I sent v2 now doing this instead.

    Arnd