linux-kernel - Re: [PATCH 8/8] maple_tree: refine mab_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221220150550.y5kknqwjc7q5bv75@revolver>
Date:   Tue, 20 Dec 2022 15:05:52 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Vernon Yang <vernon2gm@...il.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 8/8] maple_tree: refine mab_calc_split function

* Vernon Yang <vernon2gm@...il.com> [221220 09:26]:
> Invert the conditional judgment of the mid_split, to focus
> the return statement in the last statement, which is easier
> to understand and for better readability.
> 
> Signed-off-by: Vernon Yang <vernon2gm@...il.com>
> ---
>  lib/maple_tree.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 16cdcf309e97..d147669fb99c 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1882,10 +1882,9 @@ static inline int mab_calc_split(struct ma_state *mas,
>  
>  	/* Avoid ending a node on a NULL entry */
>  	split = mab_no_null_split(bn, split, slot_count);
> -	if (!(*mid_split))
> -		return split;
>  
> -	*mid_split = mab_no_null_split(bn, *mid_split, slot_count);
> +	if (*mid_split)
> +		*mid_split = mab_no_null_split(bn, *mid_split, slot_count);

The function is written this way because mid_split is almost always
zero.  If you want to change this, then we should add an unlikely() to
the if statement.

>  
>  	return split;
>  }
> -- 
> 2.34.1
> 
>