linux-kernel - Re: [PATCH] cputime: remove cputime_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212210002.DIUyTDlS-lkp@intel.com>
Date:   Wed, 21 Dec 2022 00:25:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nicholas Piggin <npiggin@...il.com>, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-arch@...r.kernel.org,
        linux-s390@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Rik van Riel <riel@...riel.com>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] cputime: remove cputime_to_nsecs fallback

Hi Nicholas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on s390/features]
[also build test WARNING on tip/sched/core soc/for-next linus/master v6.1 next-20221220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicholas-Piggin/cputime-remove-cputime_to_nsecs-fallback/20221220-150845
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
patch link:    https://lore.kernel.org/r/20221220070705.2958959-1-npiggin%40gmail.com
patch subject: [PATCH] cputime: remove cputime_to_nsecs fallback
config: ia64-randconfig-c031-20221218
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/875582613c350eb1d2fe580ce2204756a0865a25
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nicholas-Piggin/cputime-remove-cputime_to_nsecs-fallback/20221220-150845
        git checkout 875582613c350eb1d2fe580ce2204756a0865a25
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash arch/ia64/kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/ia64/kernel/time.c:110:6: warning: no previous prototype for 'arch_vtime_task_switch' [-Wmissing-prototypes]
     110 | void arch_vtime_task_switch(struct task_struct *prev)
         |      ^~~~~~~~~~~~~~~~~~~~~~
   arch/ia64/kernel/time.c:259:6: warning: no previous prototype for 'ia64_init_itm' [-Wmissing-prototypes]
     259 | void ia64_init_itm(void)
         |      ^~~~~~~~~~~~~
   arch/ia64/kernel/time.c:396:1: warning: no previous prototype for 'time_init' [-Wmissing-prototypes]
     396 | time_init (void)
         | ^~~~~~~~~


vim +/arch_vtime_task_switch +110 arch/ia64/kernel/time.c

5bf412cd769eb5 Frederic Weisbecker 2012-09-08  104  
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  105  /*
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  106   * Called from the context switch with interrupts disabled, to charge all
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  107   * accumulated times to the current process, and to prepare accounting on
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  108   * the next process.
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  109   */
e3942ba0405236 Frederic Weisbecker 2012-11-14 @110  void arch_vtime_task_switch(struct task_struct *prev)
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  111  {
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  112  	struct thread_info *pi = task_thread_info(prev);
baa36046d09ea6 Frederic Weisbecker 2012-06-18  113  	struct thread_info *ni = task_thread_info(current);
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  114  
8388d21468e7e7 Frederic Weisbecker 2017-01-05  115  	ni->ac_stamp = pi->ac_stamp;
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  116  	ni->ac_stime = ni->ac_utime = 0;
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  117  }
b64f34cdfe5bef Hidetoshi Seto      2008-01-29  118  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (166590 bytes)