linux-kernel - Re: [PATCH v6 1/2] dt-bindings: uwb: Device tree information for Nxp SR1XX SOCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Dec 2022 10:40:56 -0600
From:   Rob Herring <robh@...nel.org>
To:     Manjunatha Venkatesh <manjunatha.venkatesh@....com>
Cc:     axboe@...nel.dk, sunilmut@...rosoft.com, jasowang@...hat.com,
        will@...nel.org, linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        rvmanjumce@...il.com, krzysztof.kozlowski+dt@...aro.org,
        mst@...hat.com, Kwame Adwere <kwame.adwere@....com>,
        ashish.deshpande@....com, arnd@...db.d, gregkh@...uxfoundation.org,
        mikelley@...rosoft.com, javier@...igon.com, mb@...htnvm.io,
        devicetree@...r.kernel.org, ckeepax@...nsource.cirrus.com,
        bjorn.andersson@...aro.org
Subject: Re: [PATCH v6 1/2] dt-bindings: uwb: Device tree information for Nxp
 SR1XX SOCs


On Tue, 20 Dec 2022 21:17:46 +0530, Manjunatha Venkatesh wrote:
> Ultra-wideband (UWB) is a short-range wireless communication protocol.
> 
> NXP has SR1XX family of UWB Subsystems (UWBS) devices. SR1XX SOCs
> are FiRa Compliant. SR1XX SOCs are flash less devices and they need
> Firmware Download on every device boot. More details on the SR1XX Family
> can be found at https://www.nxp.com/products/:UWB-TRIMENSION
> 
> The sr1xx driver work the SR1XX Family of UWBS, and uses UWB Controller
> Interface (UCI).  The corresponding details are available in the FiRa
> Consortium Website (https://www.firaconsortium.org/).
> 
> Link: https://lore.kernel.org/r/425858dc-59fe-2311-61ae-3b6dc77a2576@nxp.com
> Signed-off-by: Manjunatha Venkatesh <manjunatha.venkatesh@....com>
> Signed-off-by: Kwame Adwere <kwame.adwere@....com>
> ---
> Changes since v5:
>   - Moved ioctl command definitions into header file.
>   - Version 5 patch review comments addressed.
>   - Corporate lawyer sign-off updated.
> 
>  .../bindings/uwb/nxp,uwb-sr1xx.yaml           | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.yaml:8:8: [warning] too many spaces after colon (colons)

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.example.dts:31.31-32 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221220154747.2372597-2-manjunatha.venkatesh@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.